Skip to content

Switch package manager from npm to yarn #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Carifio24 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Switch package manager from npm to yarn #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd8c3bf
Replace package-lock.json with yarn.lock.
Carifio24 Apr 14, 2026
b65c01a
Update Dockerfile and package script.
Carifio24 Apr 14, 2026
beb8d3c
Move type and testing dependencies into dev dependencies.
Carifio24 Apr 14, 2026
5423e3f
Update lockfile for new Yarn version.
Carifio24 Apr 14, 2026
0abf251
Update CI workflow to use yarn.
Carifio24 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
with:
node-version: '22.14.0'

- name: Install modules
run: npm install
- name: Install dependencies
run: yarn install

- name: Run ESLint
run: npm run lint
- name: Lint
run: yarn lint

- name: Build
run: npm run build
run: yarn build

- name: Start MySQL service
run: sudo systemctl start mysql.service
Expand All @@ -38,7 +38,7 @@ jobs:
DB_TEST_USERNAME: root
DB_TEST_PASSWORD: root
CDS_API_KEY: TEST_API_KEY
run: npm run test
run: yarn test

- name: Check OpenAPI specs
env:
Expand All @@ -51,7 +51,7 @@ jobs:
mysql -u ${DB_USERNAME} -p"${DB_PASSWORD}" -e "CREATE DATABASE IF NOT EXISTS ${DB_NAME};"
mysql -u ${DB_USERNAME} -p"${DB_PASSWORD}" ${DB_NAME} < src/sql/create_story_table.sql

npm run start &
yarn start &
sleep 10 # Give the app time to start up
specs=("" "/hubbles_law")
for spec in "${specs[@]}"; do
Expand Down
5 changes: 3 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ COPY .eslintrc.json package*.json tsconfig.json ./
COPY src ./src
COPY tests ./tests

RUN npm ci
RUN npm run build
RUN npm install -g yarn
RUN yarn
RUN yarn build

ARG port=8080
EXPOSE $port
Expand Down
Loading
Loading