Use NASA Grantee logo#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, this updates the story to use the NASA Grantee logo rather than the NASA Partner one. This time the change is in a local component. This also fixes some preexisting bad alt text for the NASA logo.
This also ignores a typing issue where, at least for me, the type checker wasn't picking up the component's
$vuetifyfrom the Vuetify plugin. It's only a typing issue - I've verified thatthis.$vuetifyexists at runtime. Normally I'd want to hunt down why this is happening, but we don't use this type of setup anymore (as we've moved to the Composition API), and this story is finished, so it's really not the worth the time.