Don't pan camera when path of Sun fits in FoV#56
Merged
Conversation
Carifio24
force-pushed
the
no-pan-in-fov
branch
from
7e872af to
6f70add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #52. The idea here is to split the "camera tracking" logic into two pieces - whether or not the user has selected the "Track Sun" checkbox, and whether or not the path lies in the FoV.
forceCamerais now a computed that is true when both the checkbox is checked and the path does NOT lie completely in the FoV.Because only the vertical extent of the FoV is preserved on a resize, we need to redetermine whether the path lies in the FoV when the WWT canvas is resized.