Add analemma layer#61
Draft
Carifio24 wants to merge 4 commits into
Draft
Conversation
Contributor
|
It looks like you are doing it correctly, at least consistently, to me. The analemma shows the difference between clock time and solar time. Since you start on the first of the year, then at least for the US, your implementation of just skipping for 86,400,000 ms at a time should keep you inline with UTC. Some southern hemisphere places seem to do daylight savings in the winter. So the only change I might make would be to |
…er selected locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for creating a layer representing an analemma. Currently the analemma can be created with a few options:
Right now this layer is connected to the current location - when the location is changed, the underlying alt/az positions will be recauclated.
There is one issue with this - I imagine that the analemma is more useful as something represented relative to the horizon (i.e. in alt/az space), but WWT wants positions in RA/Dec. This means that we need to recalculate the RA/Dec on each frame. When the engine is playing this doesn't look too bad, but it can be slightly jumpy when moving the time slider.
Finally, this doesn't take daylight savings into account at all - the analemma points are all 24 hours apart, without any adjustment when the time zone for a given location changes. Not sure how/if we want to consider that.
CC @patudom