Skip to content

Update tsconfig.json for typescript 6.0#11

Merged
Carifio24 merged 2 commits into
cosmicds:mainfrom
johnarban:keep-on-typescript-5
Mar 28, 2026
Merged

Update tsconfig.json for typescript 6.0#11
Carifio24 merged 2 commits into
cosmicds:mainfrom
johnarban:keep-on-typescript-5

Conversation

@johnarban

Copy link
Copy Markdown
Contributor

Typescript recently updated to version 6.0. Since we have typescript: latest in our package.json it used the major version. Initially I just locked us to typescript 5. But checking the typescript docs for the changes TS 6.0 Default Changes, and our error TS2882: Cannot find module or type declarations for side-effect import, the only actual change needed is to set noUncheckedSideEffectImports = false in tsconfig.json

Also note, the build and deploy workflows for this project are older, so it doesn't warn about changing lockfiles

@johnarban johnarban requested a review from Carifio24 March 27, 2026 18:26
@Carifio24

Copy link
Copy Markdown
Member

Great catch @johnarban! I'm wondering whether we do want to pin TypeScript to ^6, just so that we don't have any issues in the future when 7 comes out.

@johnarban

Copy link
Copy Markdown
Contributor Author

Great catch @johnarban! I'm wondering whether we do want to pin TypeScript to ^6, just so that we don't have any issues in the future when 7 comes out.

That is probably a good idea @Carifio24. I don't think this story needs it, but for future one's certainly should

@Carifio24 Carifio24 merged commit 77f78a7 into cosmicds:main Mar 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants