Repository navigation
refactor(cli): drop --fallback-dir - #6
Merged
Merged
Conversation
The option moves out of this repository's scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
--fallback-diroption fromtypst compile; the option moves out of this repository's scope.Removed
--fallback-dirflag (args.rs).SystemFiles::resolve/load(world.rs), back to the upstream shape.FallbackDirNotFound/FallbackDirNotADirectoryworld-creation errors and the matching retry arm inwatch.rs.world.rs) and integration tests (tests/cnd.rs).CONTEXT.md.Kept
--format cnd,--inputs-file, font files in--depsreported by canonical path.deps_report_font_files_by_their_canonical_pathnow exercises only--font-path(a symlinked directory outside the root, a relative path inside it).Test plan
cargo fmt --all -- --checkcargo clippy -p typst-cli -p typst-cnd --all-targets -- -D warningscargo test -p typst-cnd,cargo test -p typst-clicargo test --workspace --no-fail-fast(285 unit/integration passed, 0 failed; 3779 suite tests passed)git grep -n fallback crates/typst-cli: only an unrelated mention of glyph fallback remains🤖 Generated with Claude Code