Skip to content

fix(ui): synchronize hero grid gaps with visible labels - #922

Merged
pasqualevitiello merged 1 commit into
mainfrom
codex/fix-hero-grid-gaps
Nov 14, 2026
Merged

pasqualevitiello merged 1 commit into
mainfrom
codex/fix-hero-grid-gaps

Conversation

@pasqualevitiello

@pasqualevitiello pasqualevitiello commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The /ui hero grid had permanent breaks for annotations belonging to other animation stages. Those breaks stayed visible even when the labels were hidden.

Before: fixed label gaps throughout the animation
After:  continuous grid → label appears → matching gap → label fades → grid returns

Draw complete grid lines and apply label masks using the same stage and annotation visibility timelines as the labels. Preserve the existing masks for overlapping construction guides. Share the switch thumb and radius visibility animations so their masks remain synchronized across repeated cycles.

Evidence

  • Before: reproduced blank grid segments on the live /ui page, including in the Card stage where the corresponding labels were absent.
    After: inspected the corrected Card and Switch stages locally; unrelated gaps are restored.
  • Browser assertions passed at 48 timeline positions spanning all six stages over two cycles, including label entry, hold, fade, and hidden states.
  • Eight additional switch-radius samples matched label and mask opacity, including the second cycle.
  • Application and test TypeScript checks passed.
  • Scoped Biome and git diff --check passed.
  • Existing repository-wide hooks encounter nested Biome configuration conflicts in .claude/worktrees; scoped checks were run directly.

Merge Danger

Door: two-way

Reversible SVG rendering correction.

Blast Radius: website

Only the animated primitives illustration on /ui. The static fallback, geometry, and animation timing are unchanged.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
coss-com Ready Ready Preview Nov 9, 2026 11:37am UTC
coss-com-ui Ready Ready Preview Nov 9, 2026 11:37am UTC
coss-examples-calcom Ready Ready Preview Nov 9, 2026 11:37am UTC
1 Skipped Deployment
Project Deployment Actions Updated
coss-com-origin Skipped Skipped Nov 9, 2026 11:37am UTC

Request Review

@pasqualevitiello
pasqualevitiello merged commit 0da83f8 into main Nov 14, 2026
14 checks passed
@pasqualevitiello
pasqualevitiello deleted the codex/fix-hero-grid-gaps branch November 14, 2026 07:44

This branch was successfully deployed

3 active and 1 inactive deployments
Preview – coss-com-ui — 9227c4f8 Deployed Nov 9, 2026 by vercel[bot]
Preview – coss-com — 9227c4f8 Deployed Nov 9, 2026 by vercel[bot]
Preview – coss-examples-calcom — 9227c4f8 Deployed Nov 9, 2026 by vercel[bot]
Preview – coss-com-origin — 9227c4f8 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants