CBL-7773: Remove date.h and use std::chrono - #2420
Open
jianminzhao wants to merge 1 commit into
Open
Conversation
jianminzhao
force-pushed
the
cbl-7773
branch
4 times, most recently
from
January 18, 2026 01:23
c61953e to
f558458
Compare
|
Code Coverage Results:
|
jianminzhao
force-pushed
the
cbl-7773
branch
3 times, most recently
from
September 1, 2026 00:11
e3b2dd3 to
c0a605c
Compare
date.h (Howard Hinnant's date library) is fully removed. In its place, a single function, fleece::format(fmt, tp) in ParseDate.hh, is the one seam for the piece of std::chrono that still isn't consistently available everywhere: std::format's chrono-aware formatting. It calls std::format directly wherever a toolchain has it, and falls back to a small hand-written formatter otherwise, covering just the specifiers this codebase needs (%F, %T, %Y, %m, %d, %H, %M, %S, %A, %c). That fallback reproduces date.h's own logic, verified to produce byte-identical output, without depending on it. Once Linux's toolchain baseline reaches libstdc++ 13+, dropping this is a single, isolated change: remove the __linux__ clause from the "laggers" condition at the top of ParseDate.hh, and associated associated source. Nothing else needs to change. - Changed Jenkins agent for iOS and MacOS from "sonoma" to "tahoe"
jianminzhao
force-pushed
the
cbl-7773
branch
from
September 1, 2026 00:25
c0a605c to
fcb5766
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.