Skip to content

Refactored WebSocketImpl to fix thread-safety #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
snej wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Refactored WebSocketImpl to fix thread-safety #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac7fe95
Refactored WebSocketImpl to fix thread-safety
snej Feb 4, 2026
1aa40ba
WebSocketImpl: Improved handling of deferred tasks
snej Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions LiteCore/Logging/Logging.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ namespace litecore {

private:
friend class LogDomain;
friend class LoggingProxy;

mutable LogObjectRef _objectRef{};
};
Expand All @@ -216,4 +217,26 @@ namespace litecore {
# define logDebug(FMT, ...)
#endif

/** A class that delegates logging methods to an instance of Logging. */
class LoggingProxy {
public:
explicit LoggingProxy(Logging* logging) : _logging(logging) {}

protected:
bool willLog(LogLevel level = LogLevel::Info) const { return _logging->willLog(level); }

void warn(const char* format, ...) const __printflike(2, 3) { LOGBODY(Warning) }

void logError(const char* format, ...) const __printflike(2, 3) { LOGBODY(Error) }

void _log(LogLevel level, const char* format, ...) const __printflike(3, 4) { LOGBODY_(level) }

void _logv(LogLevel level, const char* format, va_list args) const __printflike(3, 0) {
_logging->_logv(level, format, args);
}

private:
Logging* const _logging;
};

} // namespace litecore
Loading