CBL-8475: Use AtomicRetained in Replicator::Subreplicators - #2503
Merged
Conversation
|
This is a release branch and commits are restricted. Please confirm this PR is one of the following:
|
Member
|
The downstream stuff needs to go into fleece release/4.1 before it can go into lite-core release/4.1 |
snej
force-pushed
the
fix/mailbox-race-CBL-8475
branch
from
June 17, 2026 16:02
3f6592f to
5c7f544
Compare
Fixes a race condition when a Replicator is torn down.
snej
force-pushed
the
fix/mailbox-race-CBL-8475
branch
from
June 17, 2026 19:34
5c7f544 to
b185aef
Compare
Collaborator
Author
|
Ubuntu build failed with a GCC error building Fleece tests. Why wasn't this caught by Fleece's CI? ... hm, one difference is that Fleece's Ubuntu builds use GCC, while LiteCore's use Clang. But Clang on macOS didn't get this error. Different versions of Clang, perhaps? |
|
Code Coverage Results:
|
borrrden
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race condition when a Replicator is torn down.
Some code had to be altered, because AtomicRetained is a bit harder to use: you have to first call
get()to get a temporary Retained object, then use that.