CBL-8554: Fix "FROM _" in queries on non-default collections - #2515
Merged
Conversation
In a query compiled by C4Collection::newQuery(), the collection name "_" should be interpreted as that collection, not the default one. The new QueryTranslator doesn't do this correctly, but we didn't notice because we didn't have any tests for it. CBL doesn't use this feature, but Edge Server does, so we need to fix it.
|
This is a release branch and commits are restricted. Please confirm this PR is one of the following:
|
|
Code Coverage Results:
|
pasin
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a query compiled by C4Collection::newQuery(), the collection name "_" should be interpreted as that collection, not the default one.
The new QueryTranslator doesn't do this correctly, but we didn't notice because we didn't have any tests for it. CBL doesn't use this feature, but Edge Server does (see CM-1658), so we need to fix it.