Fix problems with official build regarding stack traces - #299
Merged
Conversation
borrrden
commented
May 29, 2026
borrrden
commented
Member
- ARM64 build on Windows was not building because of a typo
- Backtrace test was failing because of stripped symbols (most likely). Disable it except for debug mode (PR validation)
R11 is not valid for arm64, the correct frame pointer is the FP register.
This is the exact problem we were trying to tackle anyway. Usually in release mode these symbols are stripped and so this test won't find what it's looking for. PR validation will check it anyway.
pasin
approved these changes
May 29, 2026
jianminzhao
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.