Skip to content

Remove VBucket-specific HashSet from BaseOperationImpl #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amcrn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove VBucket-specific HashSet from BaseOperationImpl #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/main/java/net/spy/memcached/protocol/BaseOperationImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,9 @@
import java.io.IOException;
import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.concurrent.atomic.AtomicLong;

import net.spy.memcached.MemcachedNode;
import net.spy.memcached.compat.SpyObject;
Expand Down Expand Up @@ -66,8 +63,6 @@ public abstract class BaseOperationImpl extends SpyObject implements Operation {
private volatile boolean timedout;
private long creationTime;
private boolean timedOutUnsent = false;
protected Collection<MemcachedNode> notMyVbucketNodes =
new HashSet<MemcachedNode>();
private long writeCompleteTimestamp;

/**
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/net/spy/memcached/protocol/binary/MultiKeyOperationImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;

import net.spy.memcached.MemcachedNode;
Expand All @@ -40,7 +41,10 @@
*/
abstract class MultiKeyOperationImpl extends OperationImpl implements
VBucketAware, KeyedOperation {

protected final Map<String, Short> vbmap;
protected Collection<MemcachedNode> notMyVbucketNodes =
new HashSet<MemcachedNode>();

protected MultiKeyOperationImpl(byte c, int o, OperationCallback cb) {
super(c, o, cb);
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/net/spy/memcached/protocol/binary/SingleKeyOperationImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;

import net.spy.memcached.MemcachedNode;
import net.spy.memcached.ops.KeyedOperation;
Expand All @@ -39,6 +40,8 @@ abstract class SingleKeyOperationImpl extends OperationImpl implements
VBucketAware, KeyedOperation {

protected final String key;
protected Collection<MemcachedNode> notMyVbucketNodes =
new HashSet<MemcachedNode>();

protected SingleKeyOperationImpl(byte c, int o, String k,
OperationCallback cb) {
Expand Down