Repository navigation
CBG-5715: attach the compaction phase enum to phase, not dry_run - #8655
Merged
Merged
Conversation
2 tasks done
Contributor
|
Droid finished @torcolvin's task —— View job Review (Pass 2: validation): approved No candidate inline comments were provided to validate. The PR diff is small and the schema changes look consistent (phase enum stays on |
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
August 23, 2026 18:33
945f83f to
7f83e18
Compare
Redocly previews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the OpenAPI schema for attachment compaction status so that the documented response matches the Go implementation: the mark/sweep/cleanup enum is applied to the phase field (where those values are actually used), and dry_run is correctly documented as a boolean.
Changes:
- Move the
mark/sweep/cleanupenum fromdry_runtophaseinCompact-status. - Add
x-enumDescriptionsdocumenting each compaction phase. - Fix
dry_runschema type fromstringtoboolean.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
August 23, 2026 18:44
7f83e18 to
9b91edd
Compare
bbrks
previously approved these changes
Aug 24, 2026
torcolvin
dismissed
bbrks’s stale review
August 24, 2026 17:31
The merge-base changed after approval.
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
August 24, 2026 17:31
9b91edd to
cf547b9
Compare
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
August 24, 2026 20:37
cf547b9 to
ad2c0e2
Compare
bbrks
previously approved these changes
Sep 7, 2026
bbrks
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
September 7, 2026 12:44
ad2c0e2 to
941b02a
Compare
bbrks
approved these changes
Sep 7, 2026
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
September 7, 2026 18:24
941b02a to
01dc126
Compare
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
September 7, 2026 19:32
01dc126 to
0c98347
Compare
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
September 7, 2026 20:02
0c98347 to
8679c97
Compare
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
September 7, 2026 20:16
8679c97 to
7c8c51b
Compare
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
September 7, 2026 20:27
7c8c51b to
a03294a
Compare
The `mark`/`sweep`/`cleanup` enum was indented one property too far down, so it constrained `dry_run` (a `bool` in Go, previously also documented as a string) while `phase` — the field that actually carries those values — was documented as an unconstrained string. Move the enum onto `phase`, document each value, and correct `dry_run` to boolean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
torcolvin
force-pushed
the
CBG-5715-07-compact-status-phase
branch
from
September 7, 2026 20:55
a03294a to
f7a64c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5715
Split out of #8589 — stack 7/9, based on #8654.
The
mark/sweep/cleanupenum was indented one property too far down, so it constraineddry_run(aboolin Go, previously also documented as a string) whilephase— the field that actually carries those values — was documented as an unconstrained string.Move the enum onto
phase, document each value, and correctdry_runto boolean.Evidence:
db/background_mgr_attachment_compaction.go:42—_phase string // current phase: "mark", "sweep", "cleanup", or "" when idle, and:327—DryRun bool json:"dry_run,omitempty".Pre-review checklist
docs/api🤖 Generated with Claude Code