CBG-4796 Match Rosmar xattr and tombstone behaviour to Couchbase Server by torcolvin · Pull Request #8832 · couchbase/sync_gateway

torcolvin · 2026-09-28T17:14:56Z

Adds tests that compare Rosmar with Couchbase Server, and updates rosmar so that it matches Couchbase Server.

Multi-xattr operations
Results of delete and remove
DeleteWithXattrs
Writes to tombstones

Pre-review checklist

Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

Blocked by Match Couchbase Server for tombstones, expiry and nil writes couchbaselabs/rosmar#101 (stacked on Stop expiring tombstones and make delete paths consistent couchbaselabs/rosmar#99)
Blocked by Treat a path mismatch in DeleteWithXattrs like a missing xattr couchbaselabs/rosmar#103
Update Go module dependencies when merged
🤖 Generated with Claude Code

Add tests comparing Rosmar and Couchbase Server for multi-xattr ops, delete/remove results, DeleteWithXattrs, and writes to tombstones, and update rosmar to match Couchbase Server behaviour. Co-authored-by: Ben Brooks <ben.brooks@couchbase.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

factory-droid · 2026-09-28T17:19:21Z

Droid finished @torcolvin's task —— View job

The change set looks directionally correct and the new cross-backend coverage is valuable. The two proposed tweaks focus on making the tests robust: avoid accidentally using CAS=0 in the “stale CAS” case, and tolerate partial xattr lookups (plus stable key comparisons) after deleting subsets of xattrs.

Copilot

Copilot review overview

🔵 Needs a closer look

A moderate xattr test assertion issue remains unresolved.

Review effort: Lite
Findings: None

What changed in this PR

Updates Rosmar and related dependencies while expanding Couchbase Server parity coverage for xattrs, deletions, CAS behavior, and tombstones.

Changes:

Upgrades Rosmar and SQLite dependencies.
Expands xattr deletion and tombstone tests.
Adds datastore operation and compatibility coverage.

File	Summary
`go.sum`	Refreshes dependency checksums.
`go.mod`	Updates Rosmar and SQLite versions.
`base/collection_xattr_test.go`	Expands xattr tombstone and deletion assertions.
`base/bucket_gocb_test.go`	Adds datastore operation and tombstone behavior tests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Update rosmar to b1384a8, which includes the merged tombstone, expiry and nil write changes. Add the matching tests from rosmar as subtests of TestTombstonesAndNilWrites, which share one bucket, and add the RemoveXattrs, DeleteSubDocPaths, Update and missing system xattr cases to the existing tests. Move SafeDocumentName to base so that base tests can use it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…d events Update rosmar to couchbaselabs/rosmar#103, which treats a path through a scalar xattr in DeleteWithXattrs like a missing xattr, as Couchbase Server does. Add the matching DeleteWithXattrsPathMismatch subtest. TestXattrOnlyWriteKeepsTombstone now checks that the DCP feed reports each xattr-only write to a tombstone as a deletion. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

torcolvin · 2026-10-09T02:22:33Z

I ported all the rosmar tests to Sync Gateway after couchbaselabs/rosmar#99 and couchbaselabs/rosmar#101 were merged and I found couchbaselabs/rosmar#103.

This PR now contains the tests that match this behavior.