Give Rosmar test buckets a source ID Couchbase Lite accepts - #8850
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The padding scheme can assign the same source ID to distinct Rosmar buckets.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds Couchbase Lite-compatible source IDs for Rosmar test buckets while retaining readable bucket-name prefixes.
Changes:
- Pads valid test bucket names into canonical 22-character source IDs.
- Falls back to production-style encoding for unsuitable names.
- Adds source ID validation tests.
| File | Description |
|---|---|
base/bucket.go |
Generates valid encoded source IDs for test buckets. |
base/bucket_test.go |
Tests encoding, fallback, and Couchbase Lite constraints. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
testing/cbltestclient parses the version vector a real Couchbase Lite client reports for a document, which uses the same format as the blip wire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
torcolvin
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prereq for real CBL testing
CBL errors if source ID is not 22 bytes and we currently produce simplified source IDs under testing to allow easier debugging.
Integration Tests