Repository navigation
Conversation
Contributor
|
Droid finished @torcolvin's task —— View job Droid review (Pass 2: validation)No candidate inline comments were provided for PR #8851, so there is nothing to post. The changes appear consistent with the intent to validate ISGR push replication reconnection and full document delivery during repeated passive DB reloads. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Each reload must wait for a newly written document rather than potentially rechecking an earlier write.
Review effort: Balanced
Findings: 1
What changed in this PR
Enables and expands the passive-database reload test for continuous push replication.
Changes:
- Runs the test across both replication protocols.
- Adds concurrent jittered writes and repeated reloads.
- Verifies document delivery and replication status.
| File | Description |
|---|---|
rest/replicatortest/replicator_test.go |
Strengthens the push-replication reload test. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
Reload the passive database several times underneath a push replication while documents are still being written on the active side, and check that the replicator reconnects and delivers every document with no write failures. - use subtest-safe names for the replication and document IDs - write documents from a wg.Go goroutine with a jittered throttle - reload with ServerContext.ReloadDatabase - wait with SGRTestRunner.WaitForDocReplicated and WaitForChanges Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gregns1
approved these changes
Oct 8, 2026
torcolvin
added a commit
that referenced
this pull request
Oct 12, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-1903: enable TestPushReplicationAPIUpdateDatabase
Reload the passive database several times underneath a push replication while documents are still being written on the active side, and check that the replicator reconnects and delivers every document with no write failures.
There is still a problem with setting
Bucket = nilbut I could not get this test reproduce that problem. I'm tempted to fix that in a separate ticket but I don't think it needs to be here.Pre-review checklist
base.UD(docID),base.MD(dbName))docs/apiIntegration Tests