Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Update mock#33

Open
ilkaynazli wants to merge 4 commits into
counsyl:masterfrom
ilkaynazli:update_mock
Open

Update mock#33
ilkaynazli wants to merge 4 commits into
counsyl:masterfrom
ilkaynazli:update_mock

Conversation

@ilkaynazli

Copy link
Copy Markdown

for compatibly to python 3.11, we either needed to remove mock in favor of the unittest.mock, or update current mock version.
I decided to remove it since python 2.7 is deprecated and unittest.mock is native to python 3+

I also removed references to six

@ilkaynazli

Copy link
Copy Markdown
Author

@jdavisp3 it looks like the previous build failed due to python 3.9. How can we resolve this issue?

@ilkaynazli

Copy link
Copy Markdown
Author

Tests pass locally
image

@jdavisp3

Copy link
Copy Markdown
Contributor

@ilkaynazli which build? can you link to it?

@ilkaynazli

Copy link
Copy Markdown
Author

@jdavisp3

Copy link
Copy Markdown
Contributor

@ilkaynazli ah, hrm, yes. I think that is going to be tricky to get the go-cd pipeline to work. I think we'd want to switch to the newer github actions pipelines for python libs. But to do that we might need to fork this repo to the myriadgenetics org and work on it from there.

@ilkaynazli

ilkaynazli commented Jan 12, 2024

Copy link
Copy Markdown
Author

is that something I can do? Are there any examples on it? Also can I get a code review on this pr, please? @jdavisp3

@jdavisp3

Copy link
Copy Markdown
Contributor

is that something I can do? Are there any examples on it? Also can I get a code review on this pr, please? @jdavisp3

Create a repo named baya in the other org and add it as a remote to your local repo and then push the main branch up there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants