Have a single install for stor to include all the packages#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jtratner
This PR handles the making stor required by each of the plugins as well as having stor require the 3 plugins, so that
pip install storstill works for the different platforms for users.Background
This is a continuation of the story to split stor across 4 modules : stor, stor_dx, stor_swift, stor_s3. This is done to easy the dependencies that need to be installed to use a particular facet of stor, and to make it more modular. This PR is preceded by #102 for this story. However, we still want
pip install storto work for everyone.Changes
stor added to requirement.txt for stor_dx, stor_swift, stor_s3
stor_dx, stor_s3, stor_swift added to requirements.txt of stor
version dynamically fixed while building sdist tarballs.
requirements-test.txt created for all packages which is a copy of requirements.txt without the inter-dependencies, to ease installation into the virtualenv for developers.
Tested via:
The complete testing suite was run successfully after making the changes. Also did sanity check.
TODOS