[BENCH-807] Rewrite roster-dependent tests to state their own models - #597
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The roster is test data now, so a test that computes its expectation by running a production function over the whole roster checks that function against itself, and a test that searches the roster for a model with some property guards a case that cannot happen. Each test now declares the rows it is about and asserts a literal result. The seed shrinks to three synthetic rows: one live STT model and two live TTS models with voice pools for the arena to pair. Catalogue tests add their own rows under a made-up provider. Prod-data invariant tests (pools are female/male pairs, live TTS has a pool, scheduled providers have code) go; the admin API enforces them at write time.
44ba922 to
78d7fc8
Compare
3 participants
The roster is test data now, so a test that computes its expectation by running a production function over the whole roster checks that function against itself, and a test that searches the roster for a model with some property guards a case that cannot happen. Each test now declares the rows it is about and asserts a literal result.
The seed shrinks to three synthetic rows: one live STT model and two live TTS models with voice pools for the arena to pair. Catalogue tests add their own rows under a made-up provider. Prod-data invariant tests (pools are female/male pairs, live TTS has a pool, scheduled providers have code) go; the admin API enforces them at write time.