Skip to content

[BENCH-810] Finish live-owned STT/TTS validation - #601

Merged
kdmelon merged 2 commits into
mainfrom
dakota/bench-810-finish-live-owned-stttts-validation-for-the-seven-day
Sep 4, 2026
Merged

[BENCH-810] Finish live-owned STT/TTS validation#601
kdmelon merged 2 commits into
mainfrom
dakota/bench-810-finish-live-owned-stttts-validation-for-the-seven-day

Conversation

@kdmelon

@kdmelon kdmelon commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow the exact live-owned timing-only failed-TTS shape while requiring proof from an existing dual-written observation
  • keep successful TTS generated-audio validation and deterministic backfill-owned comparisons strict
  • classify live conflicts into aggregate-safe categories and report bounded non-displayed provenance differences separately
  • cover malformed, foreign, duplicate, ambiguous, and unexpected child data plus dry-run idempotence and frozen bounds

Testing

  • ruff check on the changed production and test files
  • mypy --strict on the changed production and test files
  • pytest -q tests/unit/test_normalized_storage_backfill.py with the five PostgreSQL cases excluded: 63 passed, 5 deselected
  • Tier 3 Sol → Luna → Sol cycle; final Sol review passed with no findings

Known limitations and rollout gates

  • PostgreSQL-backed cases could not start on the local host because pg_config and pg_ctl are unavailable
  • the read-only production dry run must use a complete seven-day window after the BENCH-797 deployment; September 11 UTC or later is the safe point
  • this PR does not apply the backfill, deploy code, or enable normalized reads; those actions still require explicit approval

Linear: https://linear.app/coval/issue/BENCH-810/finish-live-owned-stttts-validation-for-the-seven-day-cutover

@kdmelon
kdmelon requested a review from a team as a code owner September 4, 2026 17:20

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: c214c4ec-5159-4898-a496-70c4ffcb88b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kdmelon
kdmelon added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 383c17a Sep 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants