[BENCH-835] Fix STT/TTS normalized validator false negatives - #606
Merged
kdmelon merged 1 commit intoSep 8, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seribaymadina
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed TTS requests with no audio filename and no TTFA measurement now reconcile only when an exact live-written provider-failure observation exists, including the canonical null timing artifact and its evaluation input. These cases remain ineligible for backfill.
STT observations whose metrics all fail with distinct valid errors now reconcile as succeeded observations with failed evaluations. Shared provider errors and ambiguous or malformed records retain their existing handling. Rollup comparison and read cutover behavior are unchanged.
Closes BENCH-835.
Testing
tests/unit/test_normalized_storage_backfill.py: 94 passed, including PostgreSQL-backed cases.git diff --check: passed.RunWriteranddual_write, then ran the migration CLI twice with database writes disabled. Both failure shapes reconciled with zero mismatches, identical reports, and unchanged table snapshots. Temporary servers were stopped.Deployment and production cutover validation remain separate rollout steps.