Skip to content

Mention protocol fee token explicitly#612

Open
fhenneke wants to merge 1 commit intomainfrom
add_fee_token
Open

Mention protocol fee token explicitly#612
fhenneke wants to merge 1 commit intomainfrom
add_fee_token

Conversation

@fhenneke
Copy link
Copy Markdown
Contributor

@fhenneke fhenneke commented Apr 7, 2026

Description

Add clarifying sentence on the currency protocol fees are charged in.

Summary by CodeRabbit

  • Documentation
    • Clarified protocol fee charging mechanism, specifying that fees are charged in the surplus token, with directional definitions for buy and sell orders.

@fhenneke fhenneke requested a review from a team as a code owner April 7, 2026 11:18
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Apr 7, 2026 11:19am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9eb77fcc-dd2c-49a4-a281-9f222e370446

📥 Commits

Reviewing files that changed from the base of the PR and between 669e763 and 01c80c3.

📒 Files selected for processing (1)
  • docs/governance/fees/fees.md

📝 Walkthrough

Walkthrough

This pull request adds a clarification to the fees documentation, specifying that protocol fees are charged in the surplus token, with directional definitions for buy and sell orders.

Changes

Cohort / File(s) Summary
Documentation
docs/governance/fees/fees.md
Added clarification statement defining protocol fees as charged in the surplus token, directionally specified as the buy token for sell orders and the sell token for buy orders.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A clarification, clear and bright,
Of surplus tokens, fees set right,
Buy token, sell token—the direction's true,
Governance fees now crystal through! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is incomplete and missing the 'Changes' section that lists detailed alterations as specified in the repository template. Add a 'Changes' section with a checklist of specific modifications made to clarify which aspects of the protocol fee documentation were updated.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: adding explicit mention of the protocol fee token in documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add_fee_token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant