feat!: update cow-sdk to latest version without Lens#201
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughVersion bumped to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 4: The package.json currently sets "version": "2.15.0" but this PR is a
breaking change (feat! removing Lens support); update the package version to a
new major (e.g., "3.0.0") to reflect the breaking change so downstream consumers
won't receive a silent incompatible upgrade; locate the "version" field in
package.json and change its value and update any release/changelog metadata or
CI/release scripts that derive tags from the package version (references: the
"version" field in package.json).
- Around line 48-51: The comparison at src/utils/contracts.ts (around the check
using blockNumberOrEpoch and MAX_UINT32) breaks because MAX_UINT32 is now a
bigint while blockNumberOrEpoch is an ethers BigNumber; update the comparison to
use matching types: either convert MAX_UINT32 to an ethers BigNumber (e.g., via
BigNumber.from(MAX_UINT32)) before using blockNumberOrEpoch.gt(MAX_UINT32) or
convert blockNumberOrEpoch to a bigint (via blockNumberOrEpoch.toBigInt()) and
perform a native bigint comparison; ensure this change touches the check
referencing MAX_UINT32 and the variable blockNumberOrEpoch so the runtime .gt()
call only ever receives a compatible type.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 274a1f5e-a6fb-40fb-87a4-4a73c8692244
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json
Description
@cowprotocol/dependencies to latest.config.json.examplewasn't updated because Lens wasn't there.Summary by CodeRabbit