Skip to content

chore(py): no-op sync after preserving async page_size defaults - #417

Merged
chyroc merged 2 commits into
mainfrom
refactor/remove-arg-defaults-async-sync
Feb 26, 2026
Merged

chore(py): no-op sync after preserving async page_size defaults#417
chyroc merged 2 commits into
mainfrom
refactor/remove-arg-defaults-async-sync

Conversation

@chyroc

@chyroc chyroc commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • regenerate from updated codegen where async page_size compatibility is preserved via page_size_default
  • restore async voiceprint list defaults to page_size=100
  • final downstream SDK diff vs main: 0 files changed

Upstream

Validation

  • generated via: ./scripts/genpy.sh --output-sdk /tmp/coze-py-pagesize-zI6r2k --ci-check
  • ci-check includes poetry build, ruff, mypy, pytest (285 passed)

@chyroc chyroc added the enhancement New feature or request label Feb 26, 2026
@coderabbitai

coderabbitai Bot commented Feb 26, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@chyroc has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3bd04ea and 03a3f9b.

📒 Files selected for processing (2)
  • cozepy/audio/voiceprint_groups/__init__.py
  • cozepy/audio/voiceprint_groups/features/__init__.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/remove-arg-defaults-async-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chyroc chyroc changed the title refactor(py): sync async pagination defaults after codegen cleanup chore(py): no-op sync after preserving async page_size defaults Feb 26, 2026
@chyroc

chyroc commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as no-op: async page_size compatibility was restored (page_size=100), and regenerated SDK now has zero diff vs main.

@chyroc chyroc closed this Feb 26, 2026
@codecov

codecov Bot commented Feb 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.75%. Comparing base (b912b34) to head (24fbc2a).
⚠️ Report is 4 commits behind head on main.

@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files         105      105           
  Lines        9542     9542           
=======================================
  Hits         8755     8755           
  Misses        787      787           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chyroc added a commit to coze-dev/coze-sdk-gen that referenced this pull request Feb 26, 2026
…_size_default (#55)

## Summary
- remove generic `arg_defaults_async` config support
- introduce dedicated `page_size_default` config for async `page_size`
defaults
- keep legacy behavior unchanged for voiceprint async list APIs
(`page_size=100`)
- add explicit YAML comment on these mappings: this compatibility
default must not be removed casually

## Validation
- `./scripts/fmt.sh`
- `./scripts/lint.sh`
- `./scripts/test.sh` (Total coverage: 83.2%)
- `./scripts/build.sh`
- `./scripts/gengo.sh --output-sdk exist-repo/coze-go-generated`
- `./scripts/diffgo.sh`
- `./scripts/genpy.sh --output-sdk /tmp/coze-py-pagesize-zI6r2k
--ci-check`

## Downstream
- coze-py PR: coze-dev/coze-py#417
- note: downstream branch was updated back to baseline behavior,
resulting in zero SDK diff
@chyroc chyroc reopened this Feb 26, 2026
@chyroc
chyroc merged commit 5661b28 into main Feb 26, 2026
28 checks passed
@chyroc
chyroc deleted the refactor/remove-arg-defaults-async-sync branch February 26, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant