refactor(py): sync optional file payload default behavior - #418
Conversation
📝 WalkthroughWalkthroughThe PR modifies file validation in VoiceprintGroupsFeaturesClient's update methods (both sync and async variants) by changing from a falsy check to an explicit None check, allowing empty/falsy file values to proceed through file attachment logic instead of being skipped. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 91.75% 92.15% +0.39%
==========================================
Files 105 106 +1
Lines 9542 9567 +25
==========================================
+ Hits 8755 8816 +61
+ Misses 787 751 -36
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing per request: upstream change is not needed. |
Summary
coze-sdk-genremovedfiles_exprmapping support.file is not Nonebefore constructingfiles.cozepy/audio/voiceprint_groups/features/__init__.pytests/test_audio_voiceprint_groups_features.pyUpstream
Validation
./scripts/genpy.sh --output-sdk /tmp/coze-py-DfIlej --ci-check(executed in codegen workflow)poetry run pytest tests/test_audio_voiceprint_groups_features.py