Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/talos/hack/gen-profiles.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ arch: amd64
platform: ${platform}
secureboot: false
version: ${TALOS_VERSION}
customization:
extraKernelArgs:
- cpufreq.default_governor=performance
- amd_pstate=active
- intel_idle.max_cstate=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The setting intel_idle.max_cstate=0 is very aggressive as it disables all deep power-saving C-states for Intel CPUs. While this can reduce latency, it has significant drawbacks:

  • Increased Power Consumption & Heat: Idle power consumption will increase significantly, leading to more heat.
  • Potential Performance Impact: On some Intel CPUs, disabling deep C-states can negatively affect the maximum Turbo Boost frequency. For peak performance, some cores need to enter deep sleep states to free up power/thermal budget for other cores to boost higher.

This setting is applied to all profiles, including the installer and ISO, which might be undesirable (e.g., on a laptop).

Consider using a less aggressive setting like intel_idle.max_cstate=1. This still provides good latency characteristics while being safer regarding power and turbo performance. If max_cstate=0 is intentional, please consider adding a comment to the script explaining the rationale.

Suggested change
- intel_idle.max_cstate=0
- intel_idle.max_cstate=1

input:
kernel:
path: /usr/install/amd64/vmlinuz
Expand Down
5 changes: 5 additions & 0 deletions packages/core/talos/images/talos/profiles/initramfs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ arch: amd64
platform: metal
secureboot: false
version: v1.12.1
customization:
extraKernelArgs:
- cpufreq.default_governor=performance
- amd_pstate=active
- intel_idle.max_cstate=0
input:
kernel:
path: /usr/install/amd64/vmlinuz
Expand Down
5 changes: 5 additions & 0 deletions packages/core/talos/images/talos/profiles/installer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ arch: amd64
platform: metal
secureboot: false
version: v1.12.1
customization:
extraKernelArgs:
- cpufreq.default_governor=performance
- amd_pstate=active
- intel_idle.max_cstate=0
input:
kernel:
path: /usr/install/amd64/vmlinuz
Expand Down
5 changes: 5 additions & 0 deletions packages/core/talos/images/talos/profiles/iso.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ arch: amd64
platform: metal
secureboot: false
version: v1.12.1
customization:
extraKernelArgs:
- cpufreq.default_governor=performance
- amd_pstate=active
- intel_idle.max_cstate=0
input:
kernel:
path: /usr/install/amd64/vmlinuz
Expand Down
5 changes: 5 additions & 0 deletions packages/core/talos/images/talos/profiles/kernel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ arch: amd64
platform: metal
secureboot: false
version: v1.12.1
customization:
extraKernelArgs:
- cpufreq.default_governor=performance
- amd_pstate=active
- intel_idle.max_cstate=0
input:
kernel:
path: /usr/install/amd64/vmlinuz
Expand Down
5 changes: 5 additions & 0 deletions packages/core/talos/images/talos/profiles/metal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ arch: amd64
platform: metal
secureboot: false
version: v1.12.1
customization:
extraKernelArgs:
- cpufreq.default_governor=performance
- amd_pstate=active
- intel_idle.max_cstate=0
input:
kernel:
path: /usr/install/amd64/vmlinuz
Expand Down
5 changes: 5 additions & 0 deletions packages/core/talos/images/talos/profiles/nocloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ arch: amd64
platform: nocloud
secureboot: false
version: v1.12.1
customization:
extraKernelArgs:
- cpufreq.default_governor=performance
- amd_pstate=active
- intel_idle.max_cstate=0
input:
kernel:
path: /usr/install/amd64/vmlinuz
Expand Down
Loading