Skip to content

fix(lookup): initialize map to prevent nil map assignment panic #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvaps wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(lookup): initialize map to prevent nil map assignment panic #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions pkg/engine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,11 +563,18 @@ func readUnexportedField(field reflect.Value) any {
// builds resource with metadata, spec and stringSpec fields
func extractResourceData(r resource.Resource) (map[string]interface{}, error) {
// extract metadata
o, _ := resource.MarshalYAML(r)
m, _ := yaml.Marshal(o)
var res map[string]interface{}

yaml.Unmarshal(m, &res)
o, err := resource.MarshalYAML(r)
if err != nil {
return nil, fmt.Errorf("failed to marshal resource to YAML: %w", err)
}
m, err := yaml.Marshal(o)
if err != nil {
return nil, fmt.Errorf("failed to marshal metadata to YAML: %w", err)
}
res := make(map[string]interface{})
if err := yaml.Unmarshal(m, &res); err != nil {
return nil, fmt.Errorf("failed to unmarshal metadata: %w", err)
}

// extract spec
val := reflect.ValueOf(r.Spec())
Expand Down