Repository navigation
fix: bound model requests and propagate generation and repair failures - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model responses without usage previously panicked, request retry loops could multiply across layers, and oracle/repair request failures could be swallowed. This change gives generation and repair one HTTP retry owner (at most three attempts), a configurable 180-second per-attempt timeout, explicit response validation, and propagated failures. Missing usage preserves valid answers and marks the invocation token summary incomplete.
Validation: workspace build and tests passed (38 tests; one credentialed live test intentionally ignored), along with the real-Cargo minimal pipeline and task-scheduling regressions. Local HTTP fixtures cover permanent/transient failures, exhausted retries, dropped connections and delayed bodies. CLI regressions cover oracle errors, source restoration, retained repair backups, and cached zero-request summaries. No real model service was called.
Cargo subprocess deadlines and run/resume redesign remain outside this change.