perf(coro): allocate panic snapshots lazily - #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the bounded 64-PC panic snapshot out of every runtime G and allocate it only when a managed snapshot is requested. Stackless language panics retain their scheduler-owned logical trace and pay no allocation.
The legacy SA_SIGINFO path remains allocation-free: it reuses an existing G-owned store or a static emergency store matching the already process-global fault-source semantics. Lifecycle paths release owned stores, and a source gate prevents the signal callback from reaching the allocating entry.
Measured at 10,000 parked Gs with GOMAXPROCS=1:
Validation:
The legacy PCLN signal integration command is blocked before its selected subtest by the same existing pclntab_external.go uintptr-retention audit on both this branch and exact parent c773ea5.