runtime: close native fleet idle and successor wake races - #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes
The locked ordinary-suspend fixture could publish a channel completion after standby compatibility but before the optional worker completion probe. The probe treated the now-nonempty direct-channel inbox as corruption instead of returning to the unified reducer.
The locked-G-exit fixture exposed a separate pre-existing race. A permanent clean successor retained the logical epoch from its creation, but a route advances its domain epoch after every idle/wake cycle. The next bounded slice therefore rejected an otherwise valid successor. Ordinary successors now follow the live domain epoch like initial peers; temporary successors carrying a handoff baton still require exact epoch equality.
Validation