New feature: message with priority#13
Conversation
crabhi
left a comment
crabhi
left a comment
There was a problem hiding this comment.
Thank you for this patch and I'm sorry for getting to you a bit late.
I don't have the priority queues set up in production so it's a bit harder for me to be confident about these changes.
Could you please add a test case? At least into the integration tests in the examples module. It works by spawning a RabbitMQ in a Docker container and then doing end-to-end calling of a task through this real Rabbit instance.
| @Nullable final ExecutorService executor) { | ||
| @Nullable final ExecutorService executor, | ||
| @Nullable final boolean isPriQueue, | ||
| @Nullable final int maxPriority) { |
There was a problem hiding this comment.
Could maxPriority be an Optional<Integer>? That way you wouldn't need isPriQueue parameter.
| * @return asynchronous result | ||
| * @throws IOException | ||
| */ | ||
| public AsyncResult<?> submitWithPri(String name, int priority, Object[] args) throws IOException { |
There was a problem hiding this comment.
I'd prefer if this and other methods kept the same name as the existing ones, just overloaded by parameters.
|
Hi @crabhi , I have made some changes accordingly, as well as supplying a test case(I have tested it on my local machine). |
|
Curious what the status of this is @crabhi |
3 participants
I found that if the queue in rabbitmq is a queue with priority, it will report error:
x-max-priority is none, but the queue is not
To support sending message with priority, a few changes have been made to enable priority queue