Submission download zip & ms bugfix - #64
Open
Dash-QC wants to merge 1 commit into
Open
Conversation
Dash-QC
commented
Aug 25, 2026
Dash-QC
commented
Collaborator
- Fixed a /get-submission bug where time was rounded down incorrectly by 1 ms
- Removed batch submission download in favor of zip downloads instead, with name standardisation according to Issue 23
- Added ghost-time as a field / attribute in RKGFile class, aswell as Submission table. (This may be used in the future for stream note generation perhaps, or other stuff). The newly added db field is not currently used though.
Hibyehello
approved these changes
Sep 3, 2026
Hibyehello
left a comment
Hibyehello
left a comment
Collaborator
There was a problem hiding this comment.
I have no qualms with this that I can see after reading over it, the overall logic and execution flow seem fine to me. I haven't tested it, but I don't see a reason it would have problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.