Updated getTermList to stop Fatal Error#25
Open
markwillis82 wants to merge 1 commit intocraftsmancoding:masterfrom
Open
Updated getTermList to stop Fatal Error#25markwillis82 wants to merge 1 commit intocraftsmancoding:masterfrom
markwillis82 wants to merge 1 commit intocraftsmancoding:masterfrom
Conversation
There is an edge case where if a resource has a term linked and then the page is removed (but not the link) this look causes a fatal error due to `$t->Page` being null. I've just added a sanity check to continue quietly if this happens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an edge case where if a resource has a term linked and then the page is removed (but not the link) this look causes a fatal error due to
$t->Pagebeing null.I've just added a sanity check to continue quietly if this happens