Update to Minecraft 26.3 - #17
Open
craftycorvid wants to merge 1 commit into
Open
craftycorvid wants to merge 1 commit into
craftycorvid wants to merge 1 commit into
Conversation
Bump the toolchain and dependencies to their 26.3 releases: Fabric Loader 0.19.5, Fabric API 0.161.0+26.3, Polymer 0.18.2+26.3, Server Translations API 3.2.0+26.3, YACL 3.9.5+26.3-fabric and Mod Menu 21.0.0-beta.1. Raise the loader and Minecraft requirements in fabric.mod.json to match, and move the Gradle wrapper to 9.6.0 as the Fabric 26.3 announcement recommends. 26.3 drops GLFW for SDL, so key codes must come from the vanilla InputConstants class: the atlas key binding now uses InputConstants.Type.KEYBOARD with InputConstants.KEY_M instead of GLFW.GLFW_KEY_M. Nothing else this mod calls changed between 26.2 and 26.3. Bump the mod version to 1.1. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVrP6wzcUU6e7p266T5Shq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the mod from Minecraft 26.2 to 26.3, following the Fabric 26.3 announcement.
Dependency and toolchain bumps (
gradle.properties,fabric.mod.json, Gradle wrapper)Loom stays on 1.17 and Java stays on 25, both as the announcement recommends. Mod version bumped to 1.1 so the release does not collide with the existing v1.0 tag.
Code change: 26.3 replaces GLFW with SDL, so key codes must come from vanilla
InputConstants. The atlas key binding now usesInputConstants.Type.KEYBOARDandInputConstants.KEY_Minstead ofInputConstants.Type.KEYSYMandGLFW.GLFW_KEY_M. That is the only source change needed: every other vanilla, Fabric API and Polymer member this mod calls or mixes into was checked against the 26.3 sources and is unchanged.Needs a manual step:
.github/workflows/publish.ymlThe credentials available in this session are not allowed to modify workflow files, so this diff still needs to be applied by hand on the branch:
Verification
PolymerItem,PolymerSyncedObject,PolymerItemUtilsevents and resource pack helpers are unchanged between 0.17.3 and 0.18.2.MapItem,MapItemSavedData,BundleItem,BundleContents.Mutable,CartographyTableMenu,MapRenderer,KeyMapping,Screen,GuiGraphicsExtractor,SavedDataType,ClientboundMapItemDataPacket) were checked against the 26.3 patch context in the NeoForge and Paper 26.3 branches and match the existing code../gradlew build. The session's network policy blocks maven.fabricmc.net and Mojang's servers and only JDK 21 is installed, so the build could not run here. CI on this PR is the first real compile. Three mixin details cannot be confirmed from source alone and are the places to look first if CI fails:MapInstanceMixin(local variable ordinal inMapTextureManager$MapInstance.updateTextureIfNeeded),ToastManagerMixin(intlocal inToastManager.extractRenderState) andClientBundleTooltipMixin(extractBundleWithItemsTooltipsignature).🤖 Generated with Claude Code
https://claude.ai/code/session_01WVrP6wzcUU6e7p266T5Shq
Generated by Claude Code