Switch to defineProperty; set enumerable flags to be consistent with private/public properties

[starwed]

__defineGetter and company are deprecated; this switches completely to defineProperty, and uses the enumerable flag to fix #722.

I've tested in Firefox, Chrome, and Safari. It still needs testing in IE and mobile browsers.

[mucaho]

👍
You could also remove the enumerability for viewport private properties (for consistency's sake, although it makes no difference)
Another thing to keep in mind is that Crafty.e().setter() also uses Crafty.support.setter, but that gets refactored in #708 , so I will remove that in #708 once it lands (but I'm sure that was your intention anyway :) )

[mucaho]

I was worried that the property flags could decrease the performance, but that is not the case.

[kevinsimper]

@starwed
I can test it on IE and mobile, can this be done trough the tests?

What about the #581, it will run tests in IE easy and fast :)

[starwed]

Yeah, if anything goes wrong from this it should be pretty catastrophic, so the tests should catch it! :)

I guess also check the fiddle example from 722 -- you should see both a green and a red square.

(581 looks useful.)

[starwed]

Seems to work fine on Android in the mobile versions of Firefox and Chrome.

[starwed]

@kevinsimper or anyone else check in IE?

[mucaho]

I can confirm it works for IE

[starwed]

Thanks! I'll go ahead and merge then.