fix: handle null from shell_exec('nproc') in Utils::cpuCount() (#150)#177
Merged
fix: handle null from shell_exec('nproc') in Utils::cpuCount() (#150)#177
Conversation
shell_exec('nproc') returns null when nproc is not available on the
system (e.g., minimal containers without coreutils). Casting null to
int yields 0, causing cpuCount() to return 0 — downstream this means
zero workers spawned in ServerWorker.
Fix: explicitly check for null, add trim() for shell output, and
return 1 as safe fallback.
s2x
force-pushed
the
fix/150-cpucount-null-safety
branch
from
133fa26 to
591fa68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Utils::cpuCount()returns0whenshell_exec('nproc')returnsnull(e.g., on systems withoutcoreutils/nproc). Downstream,ServerWorkerusesUtils::cpuCount() * 2for worker count → zero workers spawned.Root cause
(int) shell_exec('nproc')— whenshell_execis available but thenproccommand is not,shell_execreturnsnull, and(int) null === 0. No fallback existed.Additionally, shell output (e.g.,
"8\n") was not trimmed — relied on fragile implicit casting.Fix
shell_execreturn value explicitly fornull→ return1trim()on shell output before casting1as safe fallback when parsed count is ≤ 0Testing
testCpuCountNeverReturnsZero()— regression test for Utils::cpuCount() returns 0 when shell_exec('nproc') returns null #150