Update patch version of golang to 1.25.6 from 1.25.0#5261
Conversation
Looks like images and common modules (go.podman.io/common) updated to use 1.25.6 as minimum version from 1.25.0 which break the updates of those modules. Currently ocp golang builder image have 1.25.7 which should work and able to update those modules. ``` $ podman run --rm registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.25-openshift-4.21 go version go version go1.25.7 (Red Hat 1.25.7-1.el9_7) linux/amd64 ```
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR upgrades the Go toolchain requirement from version 1.25.0 to 1.25.6. The root ChangesGo Version Upgrade to 1.25.6
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This will unblock #5249 |
|
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like images and common modules (go.podman.io/common) updated to use 1.25.6 as minimum version from 1.25.0 which break the updates of those modules. Currently ocp golang builder image have 1.25.7 which should work and able to update those modules.
Summary by CodeRabbit
Release Notes