Skip to content

Update patch version of golang to 1.25.6 from 1.25.0#5261

Merged
praveenkumar merged 1 commit into
crc-org:mainfrom
praveenkumar:update_go_1.26
Jun 9, 2026
Merged

Update patch version of golang to 1.25.6 from 1.25.0#5261
praveenkumar merged 1 commit into
crc-org:mainfrom
praveenkumar:update_go_1.26

Conversation

@praveenkumar

@praveenkumar praveenkumar commented Jun 8, 2026

Copy link
Copy Markdown
Member

Looks like images and common modules (go.podman.io/common) updated to use 1.25.6 as minimum version from 1.25.0 which break the updates of those modules. Currently ocp golang builder image have 1.25.7 which should work and able to update those modules.

$ podman run --rm registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.25-openshift-4.21 go version
go version go1.25.7 (Red Hat 1.25.7-1.el9_7) linux/amd64

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated Go toolchain requirement from version 1.25.0 to 1.25.6 across all project modules.
    • Build configuration and dependency management scripts updated to use the new Go version specification.

Looks like images and common modules (go.podman.io/common) updated
to use 1.25.6 as minimum version from 1.25.0 which break the updates
of those modules. Currently ocp golang builder image have 1.25.7
which should work and able to update those modules.

```
$ podman run --rm registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.25-openshift-4.21 go version
go version go1.25.7 (Red Hat 1.25.7-1.el9_7) linux/amd64
```
@openshift-ci openshift-ci Bot requested review from anjannath and evidolob June 8, 2026 06:06
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8753d960-ed82-40cf-843f-73ca8fe0e163

📥 Commits

Reviewing files that changed from the base of the PR and between ca9d2f4 and 1612dca.

📒 Files selected for processing (4)
  • Makefile
  • go.mod
  • tools/go.mod
  • update-go-version.sh

Walkthrough

This PR upgrades the Go toolchain requirement from version 1.25.0 to 1.25.6. The root go.mod and tools/go.mod version directives are bumped, and the Makefile and version automation script are updated to use the matching .6 patch selector when applying Go version changes.

Changes

Go Version Upgrade to 1.25.6

Layer / File(s) Summary
Go module version directives
go.mod, tools/go.mod
Both module files update their go directive from 1.25.0 to 1.25.6.
Build and automation tooling updates
Makefile, update-go-version.sh
The vendor target now invokes go mod tidy -go $(GOVERSION).6, and the version automation script updates go.mod files to ${golang_base_version}.6 instead of .0 to maintain consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • crc-org/crc#5147: Similarly updates Go version selection consistently across go.mod, tools/go.mod, Makefile, and update-go-version.sh by changing the targeted Go patch/minor version.
  • crc-org/crc#4886: Also touches update-go-version.sh and its Go-version propagation logic for a related Go version bump.

Suggested labels

lgtm, approved

Suggested reviewers

  • cfergeau
  • anjannath
  • gbraad

Poem

🐰 A patch so small, a number so fine,
From .0 to .6, the versions align,
Makefile and scripts march in sync,
Go toolchain upgraded in a blink!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the rationale (dependency updates requiring 1.25.6) and provides evidence, but lacks the structured template elements like 'Type of change', 'Proposed changes', and 'Testing'. Complete the PR description template by adding Type of change (mark 'Chore'), Proposed changes (list all modified files), and Testing sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating Go from version 1.25.0 to 1.25.6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@praveenkumar

Copy link
Copy Markdown
Member Author

This will unblock #5249

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 1612dca link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cfergeau cfergeau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jun 8, 2026
@praveenkumar praveenkumar merged commit 868896e into crc-org:main Jun 9, 2026
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants