Improve dynamic action selection.#191
Open
j00bar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, dynamic actions via the
get_change_actionsandget_changelist_actionsmethods only impact the UI presentation of available actions. The class variables forchange_actionsandchangelist_actionsmust contain all possible actions, and the BaseActionView will respond to action requests regardless of whether the tool is in change_actions or changelist_actions and regardless of whetherget_change_actionsorget_changelist_actionswould include that action for the given request.This PR fulfills the wishlist item to make the BaseActionView respond only to the actions permitted by the dynamic action functions and only for the type of action allowed.
It attempts to maintain as much backward compatibility as possible in doing so, with an eye toward minimizing any breakage for older, customized installations.