fix: stamp today's date when a job moves into applied without one#20
Merged
Conversation
normalizeJobForSection was defaulting date to an empty string whenever a job (e.g. a prospect) moved into applied with no date set, so many board cards never showed an applied date. Default to today's date instead, and treat any falsy date (not just undefined) as missing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applied(e.g. dragging a prospect over) stampeddateas""instead of today's date.normalizeJobForSectionnow defaults to today's date (YYYY-MM-DD) wheneverdateis falsy — covering both the missing-field case and jobs that already haddate: "".Test plan
app/api/__tests__/jobs.test.ts) using fake timers to assert the DELETE-and-move-to-applied flow stamps today's datepnpm tsc --noEmitpnpm lintpnpm test(174 passed)🤖 Generated with Claude Code