Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
crhowell3
force-pushed
the
feature/77-add-live-entity-information-protocol
branch
from
December 9, 2025 00:46
7603631 to
2b99f84
Compare
crhowell3
force-pushed
the
feature/77-add-live-entity-information-protocol
branch
from
February 8, 2026 05:34
2b99f84 to
9a0f548
Compare
| #[must_use] | ||
| /// Creates a fixed-point value from meters with 3 fractional bits | ||
| pub fn from_meters(value: f32) -> Self { | ||
| Self((value * 8.0).round() as i16) |
Check failure
Code scanning / clippy
casting f32 to i16 may truncate the value Error
| #[must_use] | ||
| /// Creates a fixed-point value from meters with 3 fractional bits | ||
| pub fn from_meters(value: f32) -> Self { | ||
| Self((value * 8.0).round() as i8) |
Check failure
Code scanning / clippy
casting f32 to i8 may truncate the value Error
Comment on lines
+126
to
+128
| pub fn set_data(&mut self, value: u32) { | ||
| self.data = value; | ||
| } |
Check failure
Code scanning / clippy
this could be a const fn Error
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
Run
cargo checkandcargo test -qCloses #77