Merged
Conversation
add function to go through and mark everything as visible again when users clear the list or refresh
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #165 by improving the TreeView search/filtering behavior (including hiding non-matching resource groups/items) and fixes UI actions showing up for managed secrets where editing shouldn’t be allowed.
Changes:
- Adds an
IsVisibleflag to tree nodes and binds it to TreeViewItemVisibilityto support true hide/show filtering. - Updates
FilterServiceand search execution to reset visibility and filter against a stable read-only datasource. - Prevents “Edit version” actions from showing for managed secrets.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/KeyVaultTreeViewModel.cs | Adjusts search execution and ARM token handling while rebuilding the tree datasource. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs | Hides the edit-version button for managed secrets. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/KeyVaultTree.xaml.cs | Adjusts search debounce interval. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/KeyVaultTree.xaml | Binds TreeViewItem visibility to the new IsVisible property. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ItemDetails.xaml | Simplifies Bool-to-Visibility bindings for edit/new buttons. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/KeyVaultModel.cs | Introduces IsVisible on KvTreeNodeModel for filtering. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/FilterService.cs | Adds visibility reset and expands filtering logic to hide/show nodes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/FilterService.cs
Outdated
Show resolved
Hide resolved
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/FilterService.cs
Outdated
Show resolved
Hide resolved
...uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/KeyVaultTreeViewModel.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would close #165
Note
search works best when there is actually loaded RGs
Screen.Recording.2026-03-28.113341.mp4