Repository navigation
Fix authenticated skill publication and confirm saved decisions - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An administrator could pass the approval UI while the package remained a draft. The write used a service client that did not retain the administrator identity required by the publication trigger; an HTTP error response could also reach the success callback.
Keep RLS, roles and database triggers unchanged. Release the correction as platform0.6.5; the qualified skill archives remain0.1.4 with unchanged hashes.
Evidence
After: four actual Supabase HTTP transport regressions pass: caller JWT/version filters, trigger/RLS denial, missing row, and mismatched version/reviewer/status/publication flags.
Merge Danger
Door: two-way
Blast Radius: reviews
Writes now use the existing admin-authorized RLS path and require a confirmed saved row. Approval thresholds and publication triggers are preserved. No Lovable generation calls.