Preserve native keypad identity in terminal input - #337
Open
cristicretu wants to merge 2 commits into
Open
cristicretu wants to merge 2 commits into
cristicretu wants to merge 2 commits into
Conversation
Deploying diri with
|
| Latest commit: |
84a4883
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://32e21661.diri-53j.pages.dev |
| Branch Preview URL: | https://parity-native-keypad-identit.diri-53j.pages.dev |
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Physical numeric-keypad keys now reach the terminal's shared key encoder, including DEC application-keypad sequences. Keypad Enter stays distinct from Return; top-row digits stay ordinary characters.
The existing pinned
gpui_macospatch exposes read-only hardware metadata only during the matching synchronous callback. Nested callbacks and unwinding restore the previous context. Logical GPUI text, IME fields and shortcut identity remain unchanged. The app adds a direct edge to the already-present pinned platform crate; no new package, event monitor, timer or encoder is introduced.Stacked on #336. Legacy key releases and modified application-keypad chords retain that PR's explicit unsupported behavior.
Validation
Test evidence
Rendered results from real synthetic AppKit events and shared-encoder assertions. No OS input was posted and this is test evidence, not a GUI mockup.