Center the voice speed pill on the play button's line - #76
Closed
LisandroNahuelH wants to merge 1 commit into
Closed
LisandroNahuelH wants to merge 1 commit into
LisandroNahuelH wants to merge 1 commit into
Conversation
The player row is declared at the play button's height, but the waveform and its duration stretch it past that, and the chip is drawn last: egui cross-aligned the pill to the already stretched rect, which left it 5.5 px below the button. The pill now centers on the row's original center line, and the click area follows it. Measured with a headless layout probe: delta +5.5 px before, 0.0 px after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The speed pill under a voice note did not sit on the same line as the play button. It hung 5.5 px low, so the pair read as misaligned.
What changed
src/ui/conversation.rs: the pill is placed on the play button's middle line, instead of a fixed offset from the row.One commit, no other change.
How I verified it
26.0, pill31.5(5.5 px apart). After: both76.0(0.0 px apart).cargo build --locked --all-featuresandcargo test --locked --all-targets --all-featurespass on Windows (rustc 1.98, MSVC): 301 tests, 0 failures.Context
PR #41 is merged in
main, but this fix is not. This branch is one commit on top of the currentmain(2293f1c), so it applies clean.