fix: foundry item bonuses negate if more than one exists#2785
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where item bonuses from multiple Foundry-native items could incorrectly negate each other due to global bonus de-duplication logic treating missing/empty globalid values as the same identifier.
Changes:
- Adjusts the bonus application guard to only de-duplicate when an item has a truthy
globalid. - Avoids adding falsy
globalidvalues to the de-duplication tracking list, allowing multiple “native” items (with emptyglobalid) to each contribute bonuses.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mjeffw
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1861