fix: deleting entries from unlinked token deletes from actor#2786
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an inventory deletion bug for synthetic (unlinked token) actors in Foundry by ensuring removeKey updates the passed token actor instead of unintentionally resolving and updating the base world actor.
Changes:
- Adjusts
removeKeyto avoidgame.actors.get(actor.id)when operating on token actors (actor.isToken), preventing source actor mutation. - Adds clarifying inline comments explaining why token actors must be handled differently.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mjeffw
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
during my testing for this bug I found that when deleting an item from an unlinked token nothing initially happens but the item is then removed from the source actor after refreshing.
fixes #2052