Skip to content

adds Loader parameter to calls to yaml.load()#35

Open
kmhsonnenkind wants to merge 1 commit into
croach:masterfrom
kmhsonnenkind:master
Open

adds Loader parameter to calls to yaml.load()#35
kmhsonnenkind wants to merge 1 commit into
croach:masterfrom
kmhsonnenkind:master

Conversation

@kmhsonnenkind

Copy link
Copy Markdown

This is necessary to avoid deprecation warning in PyYAML.

see also: #34

Signed-off-by: Martin Kloesch martin.kloesch@gmail.com

This is necessary to avoid deprecation warning in PyYAML.

see also: croach#34

Signed-off-by: Martin Kloesch <martin.kloesch@gmail.com>
@kam193

kam193 commented Feb 25, 2020

Copy link
Copy Markdown

@croach Hi, could be possible to review and merge this PR? It's a small change for flask-fixtures, but a very important step to clean hundreds of warnings :)

@po5i

po5i commented Nov 17, 2021

Copy link
Copy Markdown

PyYAML in version 6.0 requires the loader, so Flask-Fixtures is not working with the updated version of PyYAML. A release of this PR would be highly appreciated.

@jkugler

jkugler commented Nov 17, 2021

Copy link
Copy Markdown

Considering this was last touched three years ago, I don't hold out much hope for a release. The best course of action may be a fork, sadly.

@po5i

po5i commented Nov 18, 2021

Copy link
Copy Markdown

Does anyone know if there's a popular and active fork for this repo? I've seen this pattern in other open source projects.

@jkugler

jkugler commented Nov 18, 2021

Copy link
Copy Markdown

These are the current forks: https://github.com/croach/Flask-Fixtures/network/members
The only one that appeared to have anything remotely recent was this one: https://github.com/captec/Flask-Fixtures
Don't know if they have plans to keep going.

@kmhsonnenkind

Copy link
Copy Markdown
Author

Is @croach still active on github? Forking would work but finding someone to take over the project would imho be the better solution. Otherwise you'd need make a new project on pypi, readthedocs and so on...

@jkugler

jkugler commented Nov 18, 2021

Copy link
Copy Markdown

@kmhsonnenkind Oh, I totally agree. It would be better if someone could take over, but too many times I see projects and/or owners go completely unresponsive, so the community ends up with no choice but to fork under a new name. Often with an "-NG" suffix. :)

@croach

croach commented Nov 18, 2021

Copy link
Copy Markdown
Owner

Hello all, and sorry for the long silence. I created this project to fill a gap that I saw in unit testing for my team within LinkedIn, and subsequently open sourced it in case anyone else could use it. Around 3 years ago, I changed my career focus to data science, and as a result, I no longer work with Flask, or this library, regularly. I do think the library is useful and would like to see it flourish, so for that reason I would welcome transferring ownership to someone that could get more use from the library. @kmhsonnenkind since you have the current pull request, I wonder if you would be interested in taking over ownership of the project? If so, let me know and I will make the transfer.

@kmhsonnenkind

Copy link
Copy Markdown
Author

Hi, now I have to apologize about the (very) late response 😞

My situation is somewhat similar to @croach as I have also shifted focus at work. I might be able to take over the repo for maintenance but not much more. Checking in every so often to review a couple of pull requests should be doable but don't expect much new development from my side...

If noone else is willing or able, I would take over though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants