Repository navigation
🐛 Fix Immich recent photo sync and thumbnail URLs - #1298
Merged
Merged
Conversation
|
🎉 This PR is included in version 1.0.0-dev.440 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immich recent sync filters by asset update time, so changes to old photos can pull them into the last-30-days import. Filter by capture time (
takenAfter) to match the setting’s description, and correct photo thumbnail URLs to/api/assets/{id}/thumbnail.Normalise trailing slashes on the photo and people API URLs, reject malformed asset-search responses instead of silently reporting an empty import, and reject repeated pagination tokens. Preserve the metadata-search endpoint, page/cursor pagination support, people pagination, and batch sizes already on dev.
Validation: All 40 Immich feature and unit tests passed with 103 assertions against the current dev dependencies (PHP 8.4.26, Laravel 13.38.0). Full Duster lint passed on the implementation and unit tests, and on the updated feature test. Tests cover page and cursor pagination, repeated tokens, malformed and empty responses, capture-date filtering, people pagination, and thumbnail URLs. Tests ran using the environment’s provided PHP container because a Sail application stack was not running.
A live end-to-end Spark sync has not been verified. No Immich memories import is included.