distro-entry.sh: remove hardcoded SDK release number#108
distro-entry.sh: remove hardcoded SDK release number#108WallaceIT wants to merge 1 commit intocrops:masterfrom
Conversation
Remove the hardcoded Poky SDK release number from the distro-entry.sh script, which will select automatically the environment setup script with the higher release version in its path. Signed-off-by: Francesco Valla <valla.francesco@gmail.com>
|
You are assuming that the Poky SDK is already installed on the host. This is not the case for the GitHub Actions build automation which creates these containers. The automation MUST continue to work with very little human intervention. Please consider refactoring to allow a default value and an option to replace with a desired value on the command line instead. For example |
|
Hi,
Given all this, I'm not sure I'm following the remark behind the Github Actions automation, as the proposed change shouldn't affect the way in which the build host works - but I'm not an expert in Github CI, so I may have missed something. Thanks for the review! |
Remove the hardcoded Poky SDK release number from the distro-entry.sh script, which will select automatically the environment setup script with the higher release version in its path.